Am I right that this PR "only" moves the getDirectoryListing call from getSmallImagePreview to generatePreviews? All other code changes are to:

* pass `previewFiles` to all the methods

* reuse some logic to make `getSmallImagePreview` smaller with `getCachedPreview` and `generateProviderPreview`

Yes, the rationale is that calling getDirectoryListing multiple times is slow and useless, since the directory won't change between two invocation, given the proximity of the code. So instead of passing previewDirectory, the list, output from getDirectoryListing($previewDirectory) is passed along.

I've noticed that getSmallImagePreview was added with Imaginary support, but the code was duplicated. Since my modifications modify the code, I gathered them in one function.

@Glandos can you rebase ? our bot cannot rebase on forks

this should help bring the branch up to date and help wake up the CI jobs that got stuck

@PVince81 commented on Jan 11, 2023, 9:01 PM GMT+1:

@Glandos can you rebase ? our bot cannot rebase on forks

this should help bring the branch up to date and help wake up the CI jobs that got stuck

Originally posted by @PVince81 in #35129 (comment)

This is now rebased on current master.

Failures seemed unrelated but restarted cypress to be sure ;)

hmmm, is background rendering using the previews endpoint ?

 /home/runner/work/server/server/cypress/snapshots/actual/theming/user-background     (1280x720)
     .cy.ts/User default background settings -- Default cloud background is not rende               
     red (failed).png